[DDI-SRG] [CDI] new Canonical XMI after model transform
Flavio Rizzolo
flavio.rizzolo at gmail.com
Fri Aug 6 09:59:24 EDT 2021
Achim: please check my answers below.
On 2021-08-06 7:41 a.m., Wackerow, Joachim wrote:
>
> Thanks Flavio, for the things you noticed. This is helpful. My
> comments are below in the message.
>
> Keep checking!
>
> Achim
>
> *From:*Flavio Rizzolo <flavio.rizzolo at gmail.com>
> *Sent:* Freitag, 6. August 2021 03:39
> *To:* Wackerow, Joachim <Joachim.Wackerow at gesis.org>; DDI Structural
> Reform Working Group. <ddi-srg at icpsr.umich.edu>
> *Subject:* Re: [DDI-SRG] [CDI] new Canonical XMI after model transform
>
> A couple of other issues:
>
> - The "refine" association seems to have a unique name now, even in
> the non-unique names xmi. For instance, Concept "refines"
> IndividualMember. Instead, we have Concept
> "Concept_refines_IndividualMember" IndividualMember.
>
> */[JW] The name should be probably removed in the regular XMI file.
> The long name should be in the version with the unique association
> names. The background of the refine names is that some UML tools are
> not able to consume the abstraction stereotypes. They just ignore them
> which results in a Abstraction relationship without further
> specification. Using the name is a workaround. But this is confusing
> in a tool like EA which can consume the abstraction stereotypes. The
> name repeats what is already expressed in the specific abstraction
> relationship. Another workaround would be to describe the kind of
> relationship in the definition./*
>
> */I will remove the names in the regular XMI file. I’ll add the long
> names to the version with the unique association names./*
>
> */You could think about if the abstraction definitions could be
> improved in a way that the kind of relationship is clear even if an
> UML tool doesn’t understand the related stereotypes like refine./*
>
I think we can name them "refines", which will be in line with the
association names. My only concern was the addition of source and target
to making them unique.
We could also use something "implements", which is more in the spirit of
using the pattern as an interface. But that might be confusing for some
people...
> - Identifier appears in all classes in the inheritance chains. For
> instance, Activity has Identifier, and so does Step, which is an
> extension of Activity. However, only the top non-abstract class in any
> inheritance chain should have Identifiable.
>
> */[JW] I didn’t think about this./*
>
> */I will remove the attribute identifier at all classes which inherit
> from a non-abstract class./*
>
> - Which brings me to the next issue: abstract classes should not be
> identifiable, should they? They are never instantiated, so it seems
> pointless they hay an identifier.
>
> */[JW] Absolutely./*
>
> */I’ll remove the attribute identifier from abstract classes./*
>
> Flavio
>
> On 2021-08-05 2:00 p.m., Flavio Rizzolo wrote:
>
> Achim,
>
> A few issues I noticed on a quick review:
>
> - The definition of Identifier seems old. It says "Basic object
> requiring identification. Elements of this type are versioned and
> provide administrative metadata properties." It's a datatype now,
> so it should probably say "identifier for objects requiring short-
> or long-lasting referencing and management", or something like
> that. The example seems wrong as well "Use for First Order Classes
> whose content does not need to be discoverable in its own right
> but needs to be related to multiple classes.". I suggest to remove it.
>
> */[JW] For the next transformation run, I would need the
> documentation of both the class attribute identifier and the data
> type Identifier. It could be the same definition./*
>
> */“Identifier for objects requiring short- or long-lasting
> referencing and management.” seems to be good enough./*
>
> */The suggested removal is fine with me./*
>
> - Some of the attributes, e.g. ddiIdentifier, uri, appear to be of
> type "EA_Java_Types_Package". I'm not sure how that happened.
>
> */[JW] I typed them as strings. I will look into this. This is an
> issue with EA and their use of UML primitives and how they express
> them in their version of XMI./*
>
Yes, it specially weird since (i) other attributes are String and appear
just fine, and (ii) EA_Java_Types_Package appears in the actual XMI, not
just within the EA tool...
> - There is a ModelIdentification datatype, right under the
> DataTypes package, that doesn't seem to be used anywhere.
>
> */[JW] I added this already to the public review version. It is
> not used anywhere in the model but it can be used by any program
> which uses the model or its representations. This way a program
> can recognize with which specification and version it deals with./*
>
> */This could stay on the level of the data types like currently or
> it could be located just below DDICDILibrary. What do you think?/*
>
I didn't know. It's fine where it is, it just needs to be documented so
that it's purpose is clear.
> - I was just going over the Documentation.xlsx and noticed a
> couple of enumerations that didn't ring a bell. I checked and
> couldn't find them in the latest EA file. They are WorkflowPattern
> and StringStructureType. There might be others. I'm not sure where
> they are coming from.
>
> */[JW] StringStructureType was removed because I simplified all
> string data types. It is now an external controlled vocabulary.
> Hard coding would be too limited./*
>
> */WorkflowPattern is not used at all. I removed it but missed to
> document it./*
>
OK. I just wanted to make sure the spreadsheet was produced from the
same source.
> *//*
>
> That's all for now. I'll keep checking.
>
> Flavio
>
> On 2021-07-30 2:59 p.m., Wackerow, Joachim wrote:
>
> I did the programmatic model transformation for a couple of
> issues we talked about. Prior to that I edited manually the EA
> model regarding some other issues.
>
> I documented all changes in
> ModelTransformation_2021-07-30.docx
> <https://www.dropbox.com/s/8fkxs38snd6ss2d/ModelTransformation_2021-07-30.docx?dl=0>.
>
> The file lists also some items which need documentation.
> Volunteers sought.
>
> While doing this work I filed a couple of additional issues:
>
> 1. Missing documentation *CDI-57*
> <https://ddi-alliance.atlassian.net/browse/CDI-57>
> 2. Boolean class attributes: should they have a default
> value? *CDI-56*
> <https://ddi-alliance.atlassian.net/browse/CDI-56>
> 3. Data type ObjectName attributes are not clear. *CDI-55*
> <https://ddi-alliance.atlassian.net/browse/CDI-55>
> 4. Data type name "SpecificationType" too generic *CDI-54*
> <https://ddi-alliance.atlassian.net/browse/CDI-54>
> 5. Review names of enumerations and data types. Several have
> the suffix 'type'. *CDI-58*
> <https://ddi-alliance.atlassian.net/browse/CDI-58>
>
> The new files include everything below DDICDIModels. The
> abstraction stereotypes like trace are maintained. Diagrams
> get lost in this process.
>
> The new XMI files (DDI-CDI_2021-07-30.xmi
> <https://www.dropbox.com/s/oizidnadhqeo1s7/DDI-CDI_2021-07-30.xmi?dl=0>,
> DDI-CDI_UniqueAssociationNames_2021-07-30.xmi
> <https://www.dropbox.com/s/sv3h4cof4i499xx/DDI-CDI_UniqueAssociationNames_2021-07-30.xmi?dl=0>)
> are available for download.
>
> Please review. There might be issues.
>
> Achim
>
>
>
> _______________________________________________
>
> DDI-SRG mailing list
>
> DDI-SRG at icpsr.umich.edu <mailto:DDI-SRG at icpsr.umich.edu>
>
> http://lists.icpsr.umich.edu/mailman/listinfo/ddi-srg <http://lists.icpsr.umich.edu/mailman/listinfo/ddi-srg>
>
>
> _______________________________________________
> DDI-SRG mailing list
> DDI-SRG at icpsr.umich.edu
> http://lists.icpsr.umich.edu/mailman/listinfo/ddi-srg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.icpsr.umich.edu/pipermail/ddi-srg/attachments/20210806/a65e3207/attachment.html
More information about the DDI-SRG
mailing list